Sophie: mozilla-thunderbird-devel-0:2.0.0.21-1mdv2009.1 x86

mozilla-thunderbird-devel-2.0.0.21-1mdv2009.1.x86_64.rpm

Thu Mar 19 2009 Funda Wang <fundawang@mandriva.org> 0:2.0.0.21-1mdv2009.1
+ Revision: 357612
- New version 2.0.0.21
Sat Mar 14 2009 Gustavo De Nardin <gustavodn@mandriva.com> 0:2.0.0.19-2mdv2009.1
+ Revision: 354800
- provide enigmail 0.95.6 for x86_64, instead of 0.95.7, that is what
upstream gives too; this fixes bug #44426
- build using gcc 4.2 in 2009.0 and newer; fixes bug #46107
- automate subrel definition when building for older distros
Wed Dec 31 2008 Funda Wang <fundawang@mandriva.org> 0:2.0.0.19-1mdv2009.1
+ Revision: 321666
- fix str fmt
- patch to enigmail Makefile is not needed any more (merged upstream)
- New version 2.0.0.19
- rediff enigmaiil patch

+ Oden Eriksson
- lowercase ImageMagick
Thu Nov 20 2008 Funda Wang <fundawang@mandriva.org> 0:2.0.0.18-1mdv2009.1
+ Revision: 304934
- New version 2.0.0.18
Mon Sep 29 2008 Funda Wang <fundawang@mandriva.org> 0:2.0.0.17-2mdv2009.0
+ Revision: 289466
- New version of enigmail
Sat Sep 27 2008 Tiago Salem <salem@mandriva.com.br> 0:2.0.0.17-1mdv2009.0
+ Revision: 288844
- version 2.0.0.17
Sat Aug 9 2008 Tiago Salem <salem@mandriva.com.br> 0:2.0.0.16-2mdv2009.0
+ Revision: 269879
- add patch to fix broken build with nss 3.12
- bump release
- fix conditionals to be able to build for the older distros.
Thu Jul 24 2008 Tiago Salem <salem@mandriva.com.br> 0:2.0.0.16-1mdv2009.0
+ Revision: 247394
- Version 2.0.0.16 fixes:
MFSA 2008-34 Remote code execution by overflowing CSS reference counter
MFSA 2008-33 Crash and remote code execution in block reflow
MFSA 2008-31 Peer-trusted certs can use alt names to spoof
MFSA 2008-29 Faulty .properties file results in uninitialized memory being used
MFSA 2008-26 Buffer length checks in MIME processing
MFSA 2008-25 Arbitrary code execution in mozIJSSubScriptLoader.loadSubScript()
MFSA 2008-24 Chrome script loading from fastload file
MFSA 2008-21 Crashes with evidence of memory corruption (rv:1.8.1.15)
- add patches to fix gcc visibility on hunspell and enigmail
- add patch from firefox to fix max_path

+ Giuseppe Ghibò
- Added Patch329 to fix MOZ#335810.
- Enable MathML in configure (mozilla-thunderbird-mozconfig).
- Added hunspell support (Patch330, deb).
Sun May 4 2008 Funda Wang <fundawang@mandriva.org> 0:2.0.0.14-1mdv2009.0
+ Revision: 200996
- New version 2.0.0.14
- new enigmail version 0.95.6

+ Tiago Salem
- do not replace /etc/thunderbird.cfg. (#40347)
- fix for cs3 build (Suggests, BuildRequires and includedirs)
Wed Mar 5 2008 Tiago Salem <salem@mandriva.com.br> 0:2.0.0.12-3mdv2008.1
+ Revision: 180131
- Disabled replytolist patches. They are making thunderbird crash.

+ Marcelo Ricardo Leitner
- Added patch russian_shortcuts: fixes problems with keyboard shortcuts and
russian locale. Closes: #38241
Wed Feb 27 2008 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0.0.12-1mdv2008.1
+ Revision: 175817
- New upstrema: 2.0.0.12
- Removed patch bug30657: already applied upstream.
Mon Feb 25 2008 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0.0.9-9mdv2008.1
+ Revision: 174797
- Disable dict links for mdkversion >= 200810. We are going to symlink entire
mozilladir/dictionaries instead. Closes: #21370
Thu Feb 14 2008 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0.0.9-8mdv2008.1
+ Revision: 168466
- Fix arch mangling.
Thu Feb 14 2008 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0.0.9-7mdv2008.1
+ Revision: 167773
- Do not tweak x86_64 arch name anymore for mdkversion >= 200810, as it causes
problems with extensions. Closes: #33103
Mon Feb 11 2008 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0.0.9-6mdv2008.1
+ Revision: 165151
- Added patch bug30657, fixing stale tmp files at $HOME/tmp. Closes: #30657
Thu Feb 7 2008 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0.0.9-5mdv2008.1
+ Revision: 163448
- Pushes soundwrapper back. RealPlayer still needs it, while Flash and Java can
live with it without problems, as stated on bug #37400.
Wed Feb 6 2008 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0.0.9-4mdv2008.1
+ Revision: 163151
- Do not use soundwrapper anymore. Closes: #37400
- Fix replytolist stuff, as list-replyto-clobber depends on replytolist patch.
- Ship a backward compatible open-browser.sh, which will be used by old
profiles using newer packages. This wrapper will just call xdg-open. Closes: #37528
- Do not touch open-browser for distros older than 2008.0.
- Added patches cups-paper and postscriptdsc, just like our FF package has
them.
- Removed replytolist stuff, in favor of list-replyto-clobber previously
applied.
- Use xdg-open for handling http, https and ftp protocols instead of a private
script.
- Added patch list-replyto-clobber: adds mailnews.clobber_list_reply pref which
switches "Reply All" to "Reply List" functionality if set (from OpenSUSE)
Mon Jan 14 2008 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0.0.9-2mdv2008.1
+ Revision: 151186
- Added suggests to pinentry-gtk to enigmail subpackage. Closes: #36685

+ Olivier Blin
- restore BuildRoot

+ Thierry Vignaud
- kill re-definition of %buildroot on Pixel's request
Wed Nov 28 2007 David Walluck <walluck@mandriva.org> 0:2.0.0.9-1mdv2008.1
+ Revision: 113622
- 2.0.0.9
Fri Nov 23 2007 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0.0.6-6mdv2008.1
+ Revision: 111541
- Adds gnome buildreqs and enable support for using gnome-vfs.
Wed Oct 31 2007 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0.0.6-5mdv2008.1
+ Revision: 104235
- Added patch bug273114 as requested by Florin.
See https://bugzilla.mozilla.org/show_bug.cgi?id=273114 for details.
- Prepared for replytolist feature. (Off for now, not working yet)
Fri Sep 14 2007 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0.0.6-4mdv2008.0
+ Revision: 85755
- Fix .desktop categories for 2008.0. Closes: #33201

+ Frederic Crozat
- Improve patch321
Fri Aug 31 2007 Frederic Crozat <fcrozat@mandriva.com> 0:2.0.0.6-3mdv2008.0
+ Revision: 77008
- Patch321: fix invalid GTK call with causes crash with GTK+ >= 2.11.0

+ Thierry Vignaud
- kill desktop-file-validate's 'warning: key "Encoding" in group "Desktop Entry" is deprecated'

+ Marcelo Ricardo Leitner
- Adds TB to X-MandrivaLinux-CrossDesktop category.
Sun Aug 5 2007 Funda Wang <fundawang@mandriva.org> 0:2.0.0.6-2mdv2008.0
+ Revision: 59066
- New version of enigmail 0.95.3
Thu Aug 2 2007 Funda Wang <fundawang@mandriva.org> 0:2.0.0.6-1mdv2008.0
+ Revision: 57989
- New version 2.0.0.6
Wed Aug 1 2007 Tomasz Pawel Gajc <tpg@mandriva.org> 0:2.0.0.5-2mdv2008.0
+ Revision: 57306
- fix build on x86_64 by exporting visibility option (bug #32024)

+ David Walluck
- x86_64 already has -fPIC
- add -fPIC to CXXFLAGS on x86_64
- update enigmail to 0.95.2

+ Funda Wang
- New version

+ Marcelo Ricardo Leitner
- Added movemail patch, fixing movemail.rdf not being installed.
Wed Jun 20 2007 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0.0.4-2mdv2008.0
+ Revision: 41863
- Added patch rss, fixing rss.rdf location. Closes: #31421
- Added patch gmail, fixing gmail.rdf location.
- Added patch g_thread_init, fixing the bug of not calling g_thread_init before
everything else. May be related with #31282.
Fri Jun 15 2007 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0.0.4-1mdv2008.0
+ Revision: 39998
- Removed patch visibility: not needed anymore.
- New upstream: 2.0.0.4
- Updated patch uriloader. Using Vincent Danen one.
- Removed patch gpg-agent: my config was broken, and not the system default
one, so we can keep the auto-detection as-is.
Mon Apr 23 2007 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0.0.0-1mdv2008.0
+ Revision: 17396
- Added patch gpg-agent: avoid auto-detection of gpg-agent, as gpg-agent seems to be run
automatically but with a strange configuration.
- Commented patch enigmail-no-upgrade, as enigmail seems to not support this anymore.
- Updated enigmail to 0.95.0
- Removed patch enigmail-version: not needed anymore.
- Removed patch dnd-nograb: already applied.
- New upstream: 2.0.0.0
Mon Mar 12 2007 Marcelo Ricardo Leitner <mrl@mandriva.com> 2.0b2-5mdv2007.1
+ Revision: 142094
- Added support for /etc/thunderbird.cfg
- Integrated with xdg-utils.
- Adds compatibility links due to name change (mozilla-thunderbird ->
thunderbird). Closes: #29128
Wed Mar 7 2007 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0b2-5mdv2007.1
+ Revision: 134522
- Added missing BuildRequires for nss-static-devel.
- Rebuild to fix libnss3 issue.
Thu Feb 15 2007 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0b2-3mdv2007.1
+ Revision: 121381
- Use only startup script provided by upstream. Closes: #28707
- Dropped startup script adopted from Fedora.
Upstream one seems better at all.
- Bumped release.
- Change devel group to Development/Other. Closes: #28146
Wed Feb 14 2007 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0b2-2mdv2007.1
+ Revision: 120784
- Added patch dnd-nograb. Closes: #28051
Fri Feb 9 2007 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:2.0b2-1mdv2007.1
+ Revision: 118428
- More improvements in order to use system's nspr.
- Use system's nspr.
- New upstream: 2.0b2
- Updated enigmail to 0.94.2
- Patched enigmail (patch 306) so it works with TB 2.0b2
- Updated some informations in mozilla-thunderbird.sh.in
- Do not enforce requires on mozilla-nspr and mozilla-nss libraries
- Do not install devel stuff by hand for now: let's use what
they are installing and see if it works.
- New tarball upstream: 2.0b2
- First 2.0 series commit
- Rediffed patches: software-update, check-default-mailer and default-applications
- Added patch x11libs.
Wed Dec 20 2006 Marcelo Ricardo Leitner <mrl@mandriva.com> 0:1.5.0.9-1mdv2007.1
+ Revision: 100459
- New upstream 1.5.0.9 with security fixes.
Thu Nov 9 2006 Frederic Crozat <fcrozat@mandriva.com> 0:1.5.0.8-1mdv2007.1
+ Revision: 79538
-Release 1.5.0.8 (security update)
-bunzip patches
-upgrade enigmail to 0.94.1
- Import mozilla-thunderbird
Sat Sep 16 2006 Frederic Crozat <fcrozat@mandriva.com> 0:1.5.0.7-1mdv2007.0
- Release 1.5.0.7 (security update)
- remove patch305, merged upstream
Thu Sep 7 2006 Frederic Crozat <fcrozat@mandriva.com> 0:1.5.0.5-3mdv2007.0
- allow build for 2006 and corp3 (Vincent Danen)
- fix the %post scripts wrt mktemp because corp3 has an older mktemp
- have to do some fiddling to get the right mkrel tag for corp3 and use
%build_for_corp3 to make it build properly
- only do the xdg stuff for %mkdversion > 200600
- this should build for all supported distros so we need the tags
Sat Aug 5 2006 Frederic Crozat <fcrozat@mandriva.com> 0:1.5.0.5-2mdv2007.0
- Fix xdg tag
- fix enigmail postun script
Fri Aug 4 2006 David Walluck <walluck@mandriva.org> 0:1.5.0.5-1mdv2007.0
- 1.5.0.5
- quiet all %setup macros
Sun Jul 9 2006 Christiaan Welvaart <cjw@daneel.dyndns.org> 0:1.5.0.4-5
- add BuildRequires: libxt-devel
Mon Jun 19 2006 David Walluck <walluck@mandriva.org> 0:1.5.0.4-4mdv2007.0
- add symlink: thunderbird -> mozilla-thunderbird
Sun Jun 18 2006 David Walluck <walluck@mandriva.org> 0:1.5.0.4-3mdv2007.0
- use BuildRequires: xft2-devel instead of BuildRequires: libxft2-devel
Wed Jun 14 2006 Frederic Crozat <fcrozat@mandriva.com> 0:1.5.0.4-2mdv2007.0
- Remove source20, inline .desktop file into specfile and fix it and migrate
to new XDG
- fix buildrequires for Mdk 2006
Sun Jun 4 2006 David Walluck <walluck@mandriva.org> 0:1.5.0.4-1mdv2007.0
- 1.5.0.4
Sun Apr 23 2006 Christiaan Welvaart <cjw@daneel.dyndns.org> 0:1.5.0.2-2mdk
- fix directory level for patch2
Sat Apr 22 2006 David Walluck <walluck@mandriva.org> 0:1.5.0.2-1mdk
- 1.5.0.2
- nable inspector, pref, and typeaheadfind extensions
Tue Apr 11 2006 Frederic Crozat <fcrozat@mandriva.com> 0:1.5-11mdk
- Add calls to gtk-update-icon-cache, all packages adding icons
into theme icon directory must run it at post/postun
Mon Apr 10 2006 David Walluck <walluck@mandriva.org> 0:1.5-10mdk
- add 64x64 and 128x128 icons (bug #21916)
Thu Apr 6 2006 Frederic Crozat <fcrozat@mandriva.com> 0:1.5-9mdk
- Enable official branding
Fri Feb 24 2006 David Walluck <walluck@mandriva.org> 0:1.5-8mdk
- version nspr and nss BuildRequires
- add versioned nspr and nss Requires
Wed Feb 22 2006 Frederic Crozat <fcrozat@mandriva.com> 0:1.5-7mdk
- fix freetype buildrequires
- Update source12, remove patch303, follow system locale
Wed Feb 15 2006 David Walluck <walluck@mandriva.org> 0:1.5-6mdk
- fix duplicate file ownership for enigmail
- fix file perms on enigmail chrome.manifest
Fri Feb 10 2006 David Walluck <walluck@mandriva.org> 0:1.5-5mdk
- package enigmail as an xpi
Thu Feb 9 2006 David Walluck <walluck@mandriva.org> 0:1.5-4mdk
- fix error in run-mozilla.sh
Wed Feb 8 2006 David Walluck <walluck@mandriva.org> 0:1.5-3mdk
- move soundwrapper call to run-mozilla.sh
- fix unofficial icons
Wed Feb 8 2006 Christiaan Welvaart <cjw@daneel.dyndns.org> 0:1.5-2mdk
- add BuildRequires: desktop-file-utils
Fri Jan 20 2006 David Walluck <walluck@mandriva.org> 0:1.5-1mdk
- 1.5
- add back devel package
- merge enigmail and enigmime packages
Wed Dec 21 2005 Per Øyvind Karlsen <pkarlsen@mandriva.com> 1.0.7-4mdk
- fix build on 10.2 (club request)
Sun Oct 16 2005 Christiaan Welvaart <cjw@daneel.dyndns.org> 0:1.0.7-3mdk
- fix version in nss-devel build dependency
Fri Oct 14 2005 Frederic Crozat <fcrozat@mandriva.com> 0:1.0.7-2mdk
- Don't package i18n pack which are already in separate packages (anne)
- Don't package empty directories
- clean up prereq dependencies
- prevent failing when uninstall packages
- force HOME value in rebuild-database script
Sat Oct 8 2005 David Walluck <walluck@mandriva.org> 0:1.0.7-1mdk
- 1.0.7
- enigmail 0.93.0
- sync patches
- remove old build date
Sat Sep 17 2005 David Walluck <walluck@mandriva.org> 0:1.0.6-7mdk
- enable xprint (#18412)
Wed Sep 14 2005 Frederic Crozat <fcrozat@mandriva.com> 1.0.6-6mdk
- Patch114 (CVS): fix idn crash
Tue Sep 6 2005 David Walluck <walluck@mandriva.org> 1.0.6-5mdk
- be sure to register enigmail extension (bug #14809)
- remove enigmail seamonkey skin and add enigmail tbird skin
- disable enigmail upgrade hotkey
- set PREF_JS_EXPORTS=prefs/enigmail.js in enigmail Makefile
- add post/preun scripts for enigmime.jar
- add other enigmail langs besides en-US
Sat Sep 3 2005 David Walluck <walluck@mandriva.org> 0:1.0.6-4mdk
- try to avoid conflicts with mozilla libraries
- remove lang directories as to not conflict with standalone rpms
Fri Aug 19 2005 Frederic Crozat <fcrozat@mandriva.com> 1.0.6-3mdk
- Update patch6 (pango is now used by default)
- Update source8 (no longer remove cache at startup, change pango variable)
- Update patch36 to remove last reference to pango-xft
Thu Aug 18 2005 Frederic Crozat <fcrozat@mandriva.com> 1.0.6-2mdk
- Add patches from Firefox package :
- Patch33: fix clipped text rendering with Pango
- Patch34: fix cursor positionning in textarea
- Patch35: fix bidi justification with pango
- Patch36: fix last Xft references
- Patch37: fix pango underline displayed as overstrike in CJK
- Patch107: fix position of IM candidate window
- Patch108: properly link with gfxshared
- Patch109: fix warning with latest GTK
- Patch110: file chooser is now modal
- Patch111: fix crash with latest GTK
- Patch112: add support for freedesktop mime-info
- Patch113: fix bad aliasing with gcc4 on x86-64 (Moz bug #293307) (CVS)
Thu Jul 21 2005 Buchan Milne <bgmilne@linux-mandrake.com> 1.0.6-1mdk
- New release 1.0.6
- drop p8,p104,p105,p107,p108 (integrated upstream)
- enigmail 0.92.0, ipc 1.1.3
- fix conditional %mkrel definition
Sat Apr 23 2005 David Walluck <walluck@mandriva.org> 0:1.0.2-3mdk
- merge patches from Fedora
- remove devel package
- fix gpg path
Wed Apr 6 2005 Frederic Crozat <fcrozat@mandrakesoft.com> 1.0.2-2mdk
- Patch8 (CVS): fix JS vulnerability (Moz bug #288688)
- Patch9 (Fedora) : add env variable to disable GNOME url handler
- Update source5 to set HOME is not set
Tue Mar 22 2005 Frederic Crozat <fcrozat@mandrakesoft.com> 1.0.2-1mdk
- Release 1.0.2 (security fix)
Wed Mar 16 2005 Frederic Crozat <fcrozat@mandrakesoft.com> 1.0-9mdk
- Patch5: fix compilation with system nspr
- Patch6: quiet extension manager (Firefox package)
- Patch7: fix extension manager (Firefox package)
- Change build directory to allow parallel build with other moz products
- build against libnspr4/libnss3 from firefox
- Remove alternative on mozilla-config
Mon Mar 14 2005 David Walluck <walluck@mandrake.org> 0:1.0-8mdk
- lang patch from Yuri Bugelli
Tue Feb 15 2005 Couriousous <couriousous@mandrake.org> 0:1.0-7mdk
- Fix dictionary detection ( don't take hyph )
Mon Feb 14 2005 David Walluck <walluck@mandrake.org> 0:1.0-6mdk
- enigmail 0.90.0
- %multiarch
- "fix" requires-on-release
- Requires: myspell-dictionary
- %mkrel (thanks Buchan Milne)
- add patch for locale detection (thanks Couriousous)
- add patch for mozilla dictionary (thanks Couriousous)
- add patch for automatic locale detection (thanks Couriousous)
Thu Dec 16 2004 Götz Waschk <waschk@linux-mandrake.com> 1.0-5mdk
- fix bug 12686, thanks to mightor
Tue Dec 14 2004 Götz Waschk <waschk@linux-mandrake.com> 1.0-4mdk
- don't try to register as default mail client on startup
Thu Dec 9 2004 Götz Waschk <waschk@linux-mandrake.com> 1.0-3mdk
- add missing file
- fix enigmail installation
Tue Dec 7 2004 Buchan Milne <bgmilne@linux-mandrake.com> 1.0-2mdk
- fix build on 10.1
- distro-specific release tag
Tue Dec 7 2004 Götz Waschk <waschk@linux-mandrake.com> 1.0-1mdk
- update enigmail
- new version
Thu Dec 2 2004 Götz Waschk <waschk@linux-mandrake.com> 1.0-0.rc.2mdk
- fix post script
Thu Dec 2 2004 Götz Waschk <waschk@linux-mandrake.com> 1.0-0.rc.1mdk
- upgrade enigmail
- remove soundwrapper
- fix post script (from firefox package)
- new version
Fri Nov 5 2004 Götz Waschk <waschk@linux-mandrake.com> 0.9-1mdk
- update ipc
- add gpg signature
- fix source URL
- New release 0.9
Fri Sep 24 2004 Götz Waschk <waschk@linux-mandrake.com> 0.8-4mdk
- drop xvfb hack, call thunderbird-bin -register instead
- upgrade enigmail to 0.86.1
Thu Sep 16 2004 Götz Waschk <waschk@linux-mandrake.com> 0.8-3mdk
- update release notes
- update enimail
Wed Sep 15 2004 Götz Waschk <waschk@linux-mandrake.com> 0.8-2mdk
- fix URL
- fix binary name
Wed Sep 15 2004 Götz Waschk <waschk@linux-mandrake.com> 0.8-1mdk
- fix installation
- fix URL
- New release 0.8
Sat Aug 7 2004 Buchan Milne <bgmilne@linux-mandrake.com> 0.7.3-2mdk
- enigmail 0.85.0
- merge fixes from Club (Thu Jul 01 2004 0.7.1-0.100.1mdk)
- enigmail 0.84.2, ipc 1.0.7
- fix scripts to not remove entries just added, and not use scripts we just
uninstalled (preuninstead of postun).
Fri Aug 6 2004 Götz Waschk <waschk@linux-mandrake.com> 0.7.3-1mdk
- increase sleep time in the postinstall script
- New release 0.7.3
Tue Jul 13 2004 Götz Waschk <waschk@linux-mandrake.com> 0.7.2-1mdk
- use hacks from the fedora package to run mozilla-thunderbird as root first
- New release 0.7.2
Thu Jul 1 2004 Götz Waschk <waschk@linux-mandrake.com> 0.7.1-1mdk
- compress source 6
- reenable libtoolize on Cooker
- fix 10.0 build
- New release 0.7.1
Tue Jun 29 2004 Guillaume Rousse <guillomovitch@mandrake.org> 0.7-2mdk
- dropped patch0, fixed upstream (Sebastian Dransfeld )
Sat Jun 26 2004 Guillaume Rousse <guillomovitch@mandrake.org> 0.7-1mdk
- new version
- --enable-single-profile
Sun Jun 13 2004 Pascal Terjan <pterjan@mandrake.org> 0.6-2mdk
- BuildRequires autoconf2.1
Fri May 21 2004 Pascal Terjan <pterjan@mandrake.org> 0.6-1mdk
- 0.6
- rediff patch0
- some cleaning, some more should be done